fsk119 commented on code in PR #21802:
URL: https://github.com/apache/flink/pull/21802#discussion_r1096883501
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/SessionContext.java:
##########
@@ -266,16 +266,20 @@ public static SessionContext create(
// Helpers
//
------------------------------------------------------------------------------------------------------------------
- public TableEnvironmentInternal createTableEnvironment() {
+ public TableEnvironmentInternal createTableEnvironment(Configuration
executionConfig) {
// checks the value of RUNTIME_MODE
final EnvironmentSettings settings =
-
EnvironmentSettings.newInstance().withConfiguration(sessionConf).build();
+ EnvironmentSettings.newInstance()
+ .withConfiguration(sessionConf)
+ .withConfiguration(executionConfig)
+ .build();
StreamExecutionEnvironment streamExecEnv =
createStreamExecutionEnvironment();
Review Comment:
When `createStreamExecutionEnvrionment`, it still uses the session conf only.
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java:
##########
@@ -486,9 +493,7 @@ public ResultFetcher callStopJobOperation(
String jobId = stopJobOperation.getJobId();
boolean isWithSavepoint = stopJobOperation.isWithSavepoint();
boolean isWithDrain = stopJobOperation.isWithDrain();
- Duration clientTimeout =
- Configuration.fromMap(sessionContext.getConfigMap())
- .get(ClientOptions.CLIENT_TIMEOUT);
+ Duration clientTimeout =
combinedConfig.get(ClientOptions.CLIENT_TIMEOUT);
Review Comment:
Use TableEnvironment#getConfig()#getConfiguration() instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
