[GitHub] [flink-benchmarks] fredia commented on pull request #63: [FLINK-27571][benchmark] Recognize 'less is better' benchmarks in regression detection script

[via GitHub]

fredia commented on PR #63:
URL: https://github.com/apache/flink-benchmarks/pull/63#issuecomment-1418515066

   @pnowojski  Thanks for your information, I overlooked this when updating 
`codespeed_benchmark` table. The colors are controlled by the[ 
group](https://github.com/tobami/codespeed/blob/263860bc298fd970c8466b3161de386582e4f801/codespeed/models.py#L444)
 of `units_title`, the code assumes that the same `units_title` has the same 
`lessIsBetter` flags, then return the table for distinct `units_title`.
   
   All the `units_title`'s were the same before, after I updated the 
`units_title`'s of lessIsBetter benchmark, the color became normal:
   
![image](https://user-images.githubusercontent.com/18653940/216885235-ee94b22f-0fb9-46b3-9061-fbf486766aa3.png)
   
   But for the default trend, the colors are still wrong due to the existence 
of the 
[cache](https://github.com/tobami/codespeed/blob/263860bc298fd970c8466b3161de386582e4f801/codespeed/models.py#L415)
   
![image](https://user-images.githubusercontent.com/18653940/216885914-56190f80-06fb-41f6-9f02-bb69ee935693.png).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org