XComp opened a new pull request, #21867:
URL: https://github.com/apache/flink/pull/21867

   ## What is the purpose of the change
   
   We experienced a test failure where the fatal error was not caused by the 
injected expected exception but a `ConnectionLossException`. The connection was 
lost because the `fsync` operation done by ZooKeeper took longer (29858ms) than 
the specified session timeout (20000ms).
   The `ConnectionLossException` can be still considered a fatal error and, 
therefore, is actually not indicating an unexpected behavior. The exception was 
properly forwarded to the error handler. We should allow this error to happen 
here.
   
   ## Brief change log
   
   The test excepts `ConnectionLossExceptions` besides the test-internal 
expected exception.
   
   ## Verifying this change
   
   I added a `testingServer.stop();` before running the assert to simulate the 
connection loss verifying that the exception is handled properly by the test.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to