Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1097361784
########## flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/sink/writer/MongoWriterITCase.java: ########## @@ -0,0 +1,424 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.mongodb.sink.writer; + +import org.apache.flink.api.common.operators.MailboxExecutor; +import org.apache.flink.api.common.operators.ProcessingTimeService; +import org.apache.flink.api.common.serialization.SerializationSchema; +import org.apache.flink.api.connector.sink2.Sink; +import org.apache.flink.connector.mongodb.common.config.MongoConnectionOptions; +import org.apache.flink.connector.mongodb.sink.config.MongoWriteOptions; +import org.apache.flink.connector.mongodb.sink.writer.context.MongoSinkContext; +import org.apache.flink.connector.mongodb.sink.writer.serializer.MongoSerializationSchema; +import org.apache.flink.connector.mongodb.testutils.MongoTestUtil; +import org.apache.flink.metrics.Counter; +import org.apache.flink.metrics.Gauge; +import org.apache.flink.metrics.MetricGroup; +import org.apache.flink.metrics.groups.OperatorIOMetricGroup; +import org.apache.flink.metrics.groups.SinkWriterMetricGroup; +import org.apache.flink.metrics.testutils.MetricListener; +import org.apache.flink.runtime.mailbox.SyncMailboxExecutor; +import org.apache.flink.runtime.metrics.MetricNames; +import org.apache.flink.runtime.metrics.groups.InternalSinkWriterMetricGroup; +import org.apache.flink.runtime.metrics.groups.UnregisteredMetricGroups; +import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration; +import org.apache.flink.streaming.runtime.tasks.TestProcessingTimeService; +import org.apache.flink.test.junit5.MiniClusterExtension; +import org.apache.flink.util.UserCodeClassLoader; + +import com.mongodb.client.MongoClient; +import com.mongodb.client.MongoClients; +import com.mongodb.client.MongoCollection; +import com.mongodb.client.model.DeleteOneModel; +import com.mongodb.client.model.InsertOneModel; +import com.mongodb.client.model.UpdateOneModel; +import com.mongodb.client.model.UpdateOptions; +import com.mongodb.client.model.WriteModel; +import org.bson.BsonDocument; +import org.bson.Document; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.RegisterExtension; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testcontainers.containers.MongoDBContainer; +import org.testcontainers.junit.jupiter.Container; +import org.testcontainers.junit.jupiter.Testcontainers; + +import java.util.Optional; +import java.util.OptionalLong; + +import static org.apache.flink.connector.mongodb.testutils.MongoTestUtil.assertThatIdsAreNotWritten; +import static org.apache.flink.connector.mongodb.testutils.MongoTestUtil.assertThatIdsAreWritten; +import static org.assertj.core.api.Assertions.assertThat; + +/** Tests for {@link MongoWriter}. */ +@Testcontainers +public class MongoWriterITCase { + + private static final Logger LOG = LoggerFactory.getLogger(MongoWriterITCase.class); + + private static final String TEST_DATABASE = "test_writer"; + + @RegisterExtension + static final MiniClusterExtension MINI_CLUSTER_RESOURCE = + new MiniClusterExtension( + new MiniClusterResourceConfiguration.Builder() + .setNumberTaskManagers(2) + .build()); + + @Container + private static final MongoDBContainer MONGO_CONTAINER = + MongoTestUtil.createMongoDBContainer(LOG); + + private static MongoClient mongoClient; + private static MetricListener metricListener; + + @BeforeAll + static void beforeAll() { + mongoClient = MongoClients.create(MONGO_CONTAINER.getConnectionString()); + } + + @AfterAll + static void afterAll() { + if (mongoClient != null) { + mongoClient.close(); + } + } + + @BeforeEach + void setUp() { + metricListener = new MetricListener(); + } + + @Test + void testWriteOnBulkFlush() throws Exception { + final String collection = "test-bulk-flush-without-checkpoint"; + final boolean flushOnCheckpoint = false; + final int batchSize = 5; + final int batchIntervalMs = -1; + + try (final MongoWriter<Document> writer = + createWriter(collection, batchSize, batchIntervalMs, flushOnCheckpoint)) { + writer.write(buildMessage(1), null); + writer.write(buildMessage(2), null); + writer.write(buildMessage(3), null); + writer.write(buildMessage(4), null); + + // Ignore flush on checkpoint + writer.flush(false); + + assertThatIdsAreNotWritten(collectionOf(collection), 1, 2, 3, 4); + + // Trigger flush + writer.write(buildMessage(5), null); + assertThatIdsAreWritten(collectionOf(collection), 1, 2, 3, 4, 5); + + writer.write(buildMessage(6), null); + assertThatIdsAreNotWritten(collectionOf(collection), 6); + + // Force flush + writer.doBulkWrite(); + assertThatIdsAreWritten(collectionOf(collection), 1, 2, 3, 4, 5, 6); + } + } + + @Test + void testWriteOnBatchIntervalFlush() throws Exception { + final String collection = "test-bulk-flush-with-interval"; + final boolean flushOnCheckpoint = false; + final int batchSize = -1; + final int batchIntervalMs = 1000; + + try (final MongoWriter<Document> writer = + createWriter(collection, batchSize, batchIntervalMs, flushOnCheckpoint)) { + writer.write(buildMessage(1), null); + writer.write(buildMessage(2), null); + writer.write(buildMessage(3), null); + writer.write(buildMessage(4), null); + writer.doBulkWrite(); + } + + assertThatIdsAreWritten(collectionOf(collection), 1, 2, 3, 4); + } + + @Test + void testWriteOnCheckpoint() throws Exception { + final String collection = "test-bulk-flush-with-checkpoint"; + final boolean flushOnCheckpoint = true; + final int batchSize = -1; + final int batchIntervalMs = -1; + + // Enable flush on checkpoint + try (final MongoWriter<Document> writer = + createWriter(collection, batchSize, batchIntervalMs, flushOnCheckpoint)) { + writer.write(buildMessage(1), null); + writer.write(buildMessage(2), null); + writer.write(buildMessage(3), null); + + assertThatIdsAreNotWritten(collectionOf(collection), 1, 2, 3); + + // Trigger flush + writer.flush(false); + + assertThatIdsAreWritten(collectionOf(collection), 1, 2, 3); + } + } + + @Test + void testIncrementRecordsSendMetric() throws Exception { + final String collection = "test-inc-records-send"; + final boolean flushOnCheckpoint = false; + final int batchSize = 2; + final int batchIntervalMs = -1; + + try (final MongoWriter<Document> writer = + createWriter(collection, batchSize, batchIntervalMs, flushOnCheckpoint)) { + final Optional<Counter> recordsSend = + metricListener.getCounter(MetricNames.NUM_RECORDS_SEND); + writer.write(buildMessage(1), null); + // Update existing index + writer.write(buildMessage(2, "u"), null); + // Delete index + writer.write(buildMessage(3, "d"), null); + + writer.doBulkWrite(); + + assertThat(recordsSend.isPresent()).isTrue(); + assertThat(recordsSend.get().getCount()).isEqualTo(3L); + } + } + + @Test + void testCurrentSendTime() throws Exception { + final String collection = "test-current-send-time"; + final boolean flushOnCheckpoint = false; + final int batchSize = 2; + final int batchIntervalMs = -1; + + try (final MongoWriter<Document> writer = + createWriter(collection, batchSize, batchIntervalMs, flushOnCheckpoint)) { + final Optional<Gauge<Long>> currentSendTime = + metricListener.getGauge("currentSendTime"); + + writer.write(buildMessage(1), null); + writer.write(buildMessage(2), null); + + writer.doBulkWrite(); + + assertThat(currentSendTime.isPresent()).isTrue(); + assertThat(currentSendTime.get().getValue()).isGreaterThan(0L); Review Comment: Thanks @zentol for reminding me of this problem. Retry mechanism has been added into this test case to make it more stable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
