Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2608#discussion_r82784524
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StandaloneCompletedCheckpointStore.java
---
@@ -64,9 +62,9 @@ public void recover() throws Exception {
@Override
public void addCheckpoint(CompletedCheckpoint checkpoint) throws
Exception {
- checkpoints.addLast(checkpoint);
+ checkpoints.add(checkpoint);
if (checkpoints.size() > maxNumberOfCheckpointsToRetain) {
- checkpoints.removeFirst().discardState();
+ checkpoints.remove().subsume();
--- End diff --
What happens if the `CheckpointProperties.discardOnSubsumed() == false`.
This could lead to files in your nfs which are not cleaned up even though they
are not useful for anything else (given that it's not a persistent checkpoint),
right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
