echauchot commented on code in PR #3:
URL:
https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1101496694
##########
flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/CassandraSplit.java:
##########
@@ -48,6 +52,30 @@ public CassandraSplitState toSplitState() {
return new CassandraSplitState(new HashSet<>(ringRanges), splitId());
}
+ public void serialize(ObjectOutputStream objectOutputStream) throws
IOException {
Review Comment:
> For symmetry I'd prefer this method to be static and accept a
CassandraSplit instance
I made the serializer take an OutputStream to avoid creating an OutputStream
for each split in the EnumeratorState serialization which would create a stream
header for each split. I managed to solve this issue by caching the
outputStream like it was done in the file source. So now I stick to the usual
serde signatures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
