reswqa opened a new pull request, #21916:
URL: https://github.com/apache/flink/pull/21916

   ## What is the purpose of the change
   
   *`ClientHeartbeatTest#testJobCancelledIfClientHeartbeatTimeout` gave an 
inappropriate timeout value(1s), which will make it very unstable. Since we 
should not rely on local timeout is the consensus of flink community() , we can 
make this test rely on global timeout to avoid this problem*
   
   ## Brief change log
   
     - *Let testJobCancelledIfClientHeartbeatTimeout rely on global timeout*
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to