zekai-li commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105708404
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+
<exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+
<exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
There you have it. Because the default character set for windows cmd is GBK,
most files are treated as non-binary files. Unix-like so far all I've seen is
utf-8 so I can tell the binaries. In order to be out of the box for users, it
is recommended that these exclusions be added. Alternatively
-Dfile.encoding=UTF-8 on mvnw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
