Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2608#discussion_r82972407
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StandaloneCompletedCheckpointStore.java
---
@@ -64,9 +62,9 @@ public void recover() throws Exception {
@Override
public void addCheckpoint(CompletedCheckpoint checkpoint) throws
Exception {
- checkpoints.addLast(checkpoint);
+ checkpoints.add(checkpoint);
if (checkpoints.size() > maxNumberOfCheckpointsToRetain) {
- checkpoints.removeFirst().discardState();
+ checkpoints.remove().subsume();
--- End diff --
Manually triggered savepoints for example are not discarded when they are
subsumed. The CheckpointProperties constructor is package private (for testing)
and only the static creator methods (for persistent checkpoints, regular
checkpoints, and manually triggered savepoints) are publicly accessible. Let me
add a check to the properties that only allow manual discard if the checkpoint
is persisted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
