[ https://issues.apache.org/jira/browse/FLINK-4512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568313#comment-15568313 ]
ASF GitHub Bot commented on FLINK-4512: --------------------------------------- Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2608#discussion_r82976383 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java --- @@ -172,7 +168,7 @@ public void recover() throws Exception { for (int i = 0; i < numberOfInitialCheckpoints - 1; i++) { try { - removeFromZooKeeperAndDiscardCheckpoint(initialCheckpoints.get(i)); + removeSubsumed(initialCheckpoints.get(i)); --- End diff -- Yes. Even more, I think this is generally dangerous. What if a checkpoint is recovered, but the checkpoint cannot be restored, than we will have lost all others. Since we currently only keep a single one anyways, it is not a problem yet. > Add option for persistent checkpoints > ------------------------------------- > > Key: FLINK-4512 > URL: https://issues.apache.org/jira/browse/FLINK-4512 > Project: Flink > Issue Type: Sub-task > Components: State Backends, Checkpointing > Reporter: Ufuk Celebi > Assignee: Ufuk Celebi > > Allow periodic checkpoints to be persisted by writing out their meta data. > This is what we currently do for savepoints, but in the future checkpoints > and savepoints are likely to diverge with respect to guarantees they give for > updatability, etc. > This means that the difference between persistent checkpoints and savepoints > in the long term will be that persistent checkpoints can only be restored > with the same job settings (like parallelism, etc.) > Regular and persisted checkpoints should behave differently with respect to > disposal in *globally* terminal job states (FINISHED, CANCELLED, FAILED): > regular checkpoints are cleaned up in all of these cases whereas persistent > checkpoints only on FINISHED. Maybe with the option to customize behaviour on > CANCELLED or FAILED. -- This message was sent by Atlassian JIRA (v6.3.4#6332)