[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

[via GitHub]

reswqa commented on code in PR #29:
URL: 
https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108066608


##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/subscriber/impl/TopicPatternSubscriber.java:
##########
@@ -52,11 +62,80 @@ public TopicPatternSubscriber(Pattern topicPattern, 
RegexSubscriptionMode subscr
         TopicName destination = TopicName.get(topicPattern.pattern());
         NamespaceName namespaceName = destination.getNamespaceObject();
         this.namespace = namespaceName.toString();
+        this.subscriptionMode = convertRegexSubscriptionMode(subscriptionMode);
+        this.useBinaryProtocol = true;
     }
 
     @Override
     public Set<TopicPartition> getSubscribedTopicPartitions(
             RangeGenerator generator, int parallelism) throws Exception {
+        Set<String> topics;
+        if (useBinaryProtocol) {
+            try {
+                topics = queryTopicsByInternalProtocols();

Review Comment:
   Fair enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org