reta commented on code in PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1110066429
##########
flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchWriter.java:
##########
@@ -122,10 +128,11 @@
} catch (Exception e) {
throw new FlinkRuntimeException("Failed to open the
OpensearchEmitter", e);
}
+ this.failureHandler = failureHandler;
}
@Override
- public void write(IN element, Context context) throws IOException,
InterruptedException {
+ public void write(IN element, Context context) throws InterruptedException
{
Review Comment:
Please revert these changes, they violate the `SinkWriter` interface
[1]
https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/api/connector/sink2/SinkWriter.java#L41
##########
flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchWriter.java:
##########
@@ -134,7 +141,7 @@ public void write(IN element, Context context) throws
IOException, InterruptedEx
}
@Override
- public void flush(boolean endOfInput) throws IOException,
InterruptedException {
+ public void flush(boolean endOfInput) throws InterruptedException {
Review Comment:
Same, please revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
