Aitozi commented on code in PR #21622:
URL: https://github.com/apache/flink/pull/21622#discussion_r1111252163
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java:
##########
@@ -1219,14 +1219,14 @@ public void applyPartitions(List<Map<String, String>>
remainingPartitions) {
} else {
// we will read data from Collections.emptyList() if
allPartitions is empty.
// therefore, we should clear all data manually.
- remainingPartitions = (List<Map<String, String>>)
Collections.emptyMap();
+ remainingPartitions = Collections.emptyList();
this.data.put(Collections.emptyMap(),
Collections.emptyList());
Review Comment:
This cast will fail, because a map can not be cast to a list (it fails when
I running test that pushing the empty list partition down)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
