Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r83141867
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer08.java
---
@@ -345,16 +343,19 @@ protected static void
validateZooKeeperConfig(Properties props) {
}
}
- private static long getInvalidOffsetBehavior(Properties config) {
+ /**
+ * Check for invalid "auto.offset.reset" values. Should be called in
constructor for eager checking before submitting
+ * the job. Note that 'none' is also considered invalid, as we don't
want to deliberately throw an exception
--- End diff --
Thanks for pointing this out. To keep things simple for now, I propose to
fix https://issues.apache.org/jira/browse/FLINK-3037 as a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
