dannycranmer commented on PR #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-1442005227
@reta The PR looks good to me minus the Mockito comment. However I have questions over the approach here. We are adding a new sink alongside the existing sink, we will have `OpensearchSink` and `OpensearchAsyncSink`. How do the users know which one to pick? Why not replace the existing sink with the new implementation? The [Jira](https://issues.apache.org/jira/browse/FLINK-31068) mentions docs, however there is no update here. Will you create a followup PR for that? If this has already been discussed on mailing lists I missed that, please give me a link :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
