reswqa commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1116565034
########## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ########## @@ -362,30 +357,28 @@ private void testSyncSavepointWithEndInput( "savepointResult"); harness.processAll(); - Assert.assertEquals(expectEndInput, TestBoundedOneInputStreamOperator.isInputEnded()); + assertThat(TestBoundedOneInputStreamOperator.isInputEnded()).isEqualTo(expectEndInput); } @Test - public void testCleanUpExceptionSuppressing() throws Exception { + void testCleanUpExceptionSuppressing() throws Exception { try (StreamTaskMailboxTestHarness<String> testHarness = new StreamTaskMailboxTestHarnessBuilder<>(OneInputStreamTask::new, STRING_TYPE_INFO) .addInput(STRING_TYPE_INFO) .setupOutputForSingletonOperatorChain(new FailingTwiceOperator()) .build()) { - try { - testHarness.processElement(new StreamRecord<>("Doesn't matter", 0)); - throw new RuntimeException("Expected an exception but ran successfully"); - } catch (Exception ex) { - ExceptionUtils.assertThrowable(ex, ExpectedTestException.class); - } + assertThatThrownBy( + () -> { + testHarness.processElement(new StreamRecord<>("Doesn't matter", 0)); + throw new RuntimeException( + "Expected an exception but ran successfully"); + }) + .isInstanceOf(ExpectedTestException.class); - try { - testHarness.finishProcessing(); - } catch (Exception ex) { - // todo: checking for suppression if there are more exceptions during cleanup - ExceptionUtils.assertThrowable(ex, FailingTwiceOperator.CloseException.class); - } + // todo: checking for suppression if there are more exceptions during cleanup + assertThatThrownBy(testHarness::finishProcessing) + .isInstanceOf(FailingTwiceOperator.CloseException.class); Review Comment: We don't need to go back to the original implementation. You can see my last comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org