JingsongLi commented on code in PR #546: URL: https://github.com/apache/flink-table-store/pull/546#discussion_r1118300656
########## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/system/SnapshotsTable.java: ########## @@ -71,7 +71,10 @@ public class SnapshotsTable implements Table { new DataField(3, "commit_identifier", new BigIntType(false)), new DataField( 4, "commit_kind", SerializationUtils.newStringType(false)), - new DataField(5, "commit_time", new TimestampType(false, 3)))); + new DataField(5, "commit_time", new TimestampType(false, 3)), + new DataField(6, "total_record_count", new BigIntType(false)), Review Comment: `BigIntType(true)`? ########## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java: ########## @@ -477,12 +477,16 @@ private boolean tryCommitOnce( List<ManifestFileMeta> newMetas = new ArrayList<>(); List<ManifestFileMeta> changelogMetas = new ArrayList<>(); try { + long previousChangesRecordCount = 0L; Review Comment: `previousTotalRecords`? ########## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java: ########## @@ -494,6 +498,7 @@ private boolean tryCommitOnce( previousChangesListName = manifestList.write(newMetas); // write new changes into manifest files + long newChangesRecordCount = Snapshot.recordCount(tableFiles); Review Comment: just `deltaRecordCount`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org