dmvk commented on code in PR #22022:
URL: https://github.com/apache/flink/pull/22022#discussion_r1123044415
##########
flink-tests/src/test/java/org/apache/flink/runtime/operators/lifecycle/graph/TestEventSource.java:
##########
@@ -103,6 +110,14 @@ private void ack(TestCommand cmd) {
@Override
public void cancel() {
+ stop();
+ }
+
+ private void stop() {
+ commandQueue.unsubscribe(operatorID, commandExecutor);
isRunning = false;
+ if (!scheduledCommands.isEmpty()) {
+ LOG.warn("Unsubscribed with remaining commands: {}",
scheduledCommands);
Review Comment:
If this happens, is still possible to time out (in
`TestJobExecutor#waitForFailover`) while waiting for failover, because we
haven't acknowledged the FAIL command?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
