reta commented on code in PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1125470984
##########
flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchWriter.java:
##########
@@ -122,10 +128,11 @@
} catch (Exception e) {
throw new FlinkRuntimeException("Failed to open the
OpensearchEmitter", e);
}
+ this.failureHandler = failureHandler;
}
@Override
- public void write(IN element, Context context) throws IOException,
InterruptedException {
+ public void write(IN element, Context context) throws InterruptedException
{
Review Comment:
@lilyevsky correct, the `throws IOException, InterruptedException` is the
right part of the signature: the first comment is about `write`, the second is
about `flush`, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
