dmvk commented on code in PR #22140: URL: https://github.com/apache/flink/pull/22140#discussion_r1132309980
########## flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/FlinkAssertions.java: ########## @@ -25,11 +25,11 @@ import org.assertj.core.api.ListAssert; import org.assertj.core.api.ThrowingConsumer; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CompletionStage; import java.util.function.Function; import java.util.stream.Stream; -import static org.assertj.core.api.Assertions.assertThat; Review Comment: We don't 👍 ; I originally named the new method `assertThat` and then renamed it because it made it hard to use in combination with `assertThat` from the `Assertions` class. Reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
