wuchong commented on code in PR #22158:
URL: https://github.com/apache/flink/pull/22158#discussion_r1133467836
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlCreateTableConverter.java:
##########
@@ -193,10 +179,7 @@ private CatalogTable createCatalogTable(SqlCreateTable
sqlCreateTable) {
return catalogManager.resolveCatalogTable(
CatalogTable.of(
- mergedSchema.toSchema(comments),
Review Comment:
But it has been exposed in 1.17 as a `@PublicEvolving` API, and it's a
breaking change if we remove it. I think we can leave it alone because
`TableSchema` is deprecated. We can remove it entirely once `TableSchema` is
dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
