SteNicholas commented on code in PR #584:
URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1136549744
##########
flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java:
##########
@@ -82,6 +82,20 @@ public class FlinkConnectorOptions {
+ "By default, if this option is not
defined, the planner will derive the parallelism "
+ "for each statement individually by also
considering the global configuration.");
+ public static final ConfigOption<Boolean> INFER_SCAN_PARALLELISM =
+ ConfigOptions.key("scan.infer-parallelism")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "If it is false, parallelism of source are set by
scan.parallelism. "
+ + "If it is true, source parallelism is
inferred according to splits number (batch mode) or bucket number(streaming
mode).");
+
+ public static final ConfigOption<Integer> INFER_SCAN_PARALLELISM_MAX =
+ ConfigOptions.key("scan.infer-parallelism.max")
Review Comment:
How does the user configure this config? Meanwhile, the essence of the
situation that many datafiles from causing excessive parallelism should be
controlled by splits number and bucket number, instead of this config. BTW, the
user doesn't know how to control the excessive inferred parallelism and no need
to care this problem. The parallelism is inferred by engine not by user,
therefore the user doesn't need to config this max parallelism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
