fredia commented on code in PR #21822:
URL: https://github.com/apache/flink/pull/21822#discussion_r1140919763
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/LocalChangelogRegistryImpl.java:
##########
@@ -58,23 +59,23 @@ public void register(StreamStateHandle handle, long
checkpointID) {
handle.getStreamStateHandleID(),
(k, v) -> {
if (v == null) {
- return Tuple2.of(handle, checkpointID);
+ return new LocalStateEntry(handle, checkpointID);
} else {
- Preconditions.checkState(handle.equals(v.f0));
- return Tuple2.of(handle, Math.max(v.f1, checkpointID));
+ Preconditions.checkState(handle.equals(v.getHandle()));
Review Comment:
No, normally there is no such case: new handle doesn't equal v.getHandle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
