Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2648#discussion_r83678698
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/ManagedInitializationContext.java
 ---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.state;
    +
    +import org.apache.flink.api.common.state.KeyedStateStore;
    +import org.apache.flink.api.common.state.OperatorStateStore;
    +
    +/**
    + * This interface provides a context in which operators can initialize by 
registering to managed state (i.e. state that
    + * is managed by state backends).
    + * <p/>
    + *
    + * Operator state is available to all operators, while keyed state is only 
available for operators after keyBy.
    + * <p/>
    + *
    + * For the purpose of initialization, the context signals if the state is 
empty (new operator) or was restored from
    + * a previous execution of this operator.
    + *
    + */
    +public interface ManagedInitializationContext {
    --- End diff --
    
    I think this interface and its sub interfaces/implementations should be in 
the same module as `AbstractStreamOperator` and somewhere in the api package 
space.
    
    Also, the naming could be changed to something like 
`StateInitializationContext` -> `FunctionInitializationContext` -> 
`OperatorInitializationContext`. Or something reflecting their purpose but 
`StateInitializationContext` should be at the bottom of the hierarchy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to