[
https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584857#comment-15584857
]
ASF GitHub Bot commented on FLINK-4715:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2652#discussion_r83800264
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -289,6 +294,10 @@ public Task(
ConfigConstants.TASK_CANCELLATION_INTERVAL_MILLIS,
ConfigConstants.DEFAULT_TASK_CANCELLATION_INTERVAL_MILLIS);
+ this.taskCancellationTimeout = jobConfiguration.getLong(
--- End diff --
I think the `jobConfiguration` is the wrong configuration here. It should
probably be the TaskManager's configuration in the `taskManagerConfig`. Same
probably holds for the cancellation interval above.
Seems neither were ever tested?
> TaskManager should commit suicide after cancellation failure
> ------------------------------------------------------------
>
> Key: FLINK-4715
> URL: https://issues.apache.org/jira/browse/FLINK-4715
> Project: Flink
> Issue Type: Improvement
> Components: TaskManager
> Affects Versions: 1.2.0
> Reporter: Till Rohrmann
> Assignee: Ufuk Celebi
> Fix For: 1.2.0
>
>
> In case of a failed cancellation, e.g. the task cannot be cancelled after a
> given time, the {{TaskManager}} should kill itself. That way we guarantee
> that there is no resource leak.
> This behaviour acts as a safety-net against faulty user code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
