huwh commented on code in PR #22183:
URL: https://github.com/apache/flink/pull/22183#discussion_r1145915258
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncer.java:
##########
@@ -308,6 +309,14 @@ private boolean syncAllocatedSlotStatus(SlotStatus
slotStatus, TaskManagerInfo t
}
}
+ @Override
+ public void freeInactiveSlots(JobID jobId, TaskExecutorConnection
taskExecutorConnection) {
+ checkStarted();
+ taskExecutorConnection
+ .getTaskExecutorGateway()
+ .freeInactiveSlots(jobId, taskManagerRequestTimeout);
+ }
Review Comment:
I would like to keep the states consistent between SlotManager and
TaskManager.
I am concern that the SlotManager try assign a slot to another job, but this
slot in TaskManager still belongs to the old job because of some
reason(freeInactiveSlots rpc received late, maybe never happens.) and then
trigger there will be a failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
