snuyanzin commented on code in PR #22277:
URL: https://github.com/apache/flink/pull/22277#discussion_r1151097522
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java:
##########
@@ -287,4 +301,46 @@ Stream<TestSetSpec> getTestSetSpecs() {
"Invalid input arguments. Expected signatures
are:\n"
+ "ARRAY_REMOVE(haystack <ARRAY>,
needle <ARRAY ELEMENT>)"));
}
+
+ private Stream<TestSetSpec> arrayReverseTestCases() {
+ return Stream.of(
+
TestSetSpec.forFunction(BuiltInFunctionDefinitions.ARRAY_REVERSE)
+ .onFieldsWithData(
+ new Integer[] {1, 2, 2, null},
+ null,
+ new Row[] {
+ Row.of(true, LocalDate.of(2022, 4, 20)),
+ Row.of(true, LocalDate.of(1990, 10, 14)),
+ Row.of(true, LocalDate.of(1990, 10, 14)),
+ Row.of(true, LocalDate.of(1990, 10, 14)),
Review Comment:
should we have all these 3 lines in the code?
It seems we cannot differentiate them... So seems not much value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
