eskabetxe commented on code in PR #22266:
URL: https://github.com/apache/flink/pull/22266#discussion_r1151668036
##########
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcExactlyOnceSinkE2eTest.java:
##########
@@ -92,25 +89,14 @@
import static org.apache.flink.util.Preconditions.checkArgument;
import static org.apache.flink.util.Preconditions.checkState;
import static org.assertj.core.api.Assertions.assertThat;
-import static org.slf4j.event.Level.TRACE;
/** A simple end-to-end test for {@link JdbcXaSinkFunction}. */
@RunWith(Parameterized.class)
public class JdbcExactlyOnceSinkE2eTest extends JdbcTestBase {
- private static final Random RANDOM = new
Random(System.currentTimeMillis());
-
private static final Logger LOG =
LoggerFactory.getLogger(JdbcExactlyOnceSinkE2eTest.class);
- private static final long CHECKPOINT_TIMEOUT_MS = 20_000L;
- private static final long TASK_CANCELLATION_TIMEOUT_MS = 20_000L;
-
- // todo: remove after fixing FLINK-22889
Review Comment:
yes removed
##########
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcExactlyOnceSinkE2eTest.java:
##########
@@ -92,25 +89,14 @@
import static org.apache.flink.util.Preconditions.checkArgument;
import static org.apache.flink.util.Preconditions.checkState;
import static org.assertj.core.api.Assertions.assertThat;
-import static org.slf4j.event.Level.TRACE;
/** A simple end-to-end test for {@link JdbcXaSinkFunction}. */
@RunWith(Parameterized.class)
public class JdbcExactlyOnceSinkE2eTest extends JdbcTestBase {
- private static final Random RANDOM = new
Random(System.currentTimeMillis());
-
private static final Logger LOG =
LoggerFactory.getLogger(JdbcExactlyOnceSinkE2eTest.class);
- private static final long CHECKPOINT_TIMEOUT_MS = 20_000L;
- private static final long TASK_CANCELLATION_TIMEOUT_MS = 20_000L;
-
- // todo: remove after fixing FLINK-22889
Review Comment:
yes, removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
