LadyForest opened a new pull request, #22300:
URL: https://github.com/apache/flink/pull/22300
## What is the purpose of the change
This PR tries to improve the error message since `row_number()` without an
order (or order by constants) does not make a lot of sense, and users are
confused about it.
## Brief change log
Improve the error message in `FlinkLogicalOverAggreate`
## Verifying this change
This change added tests and can be verified as follows:
- `RankTest` to cover both streaming and batch scenarios.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
