jeremy-degroot opened a new pull request, #20:
URL: https://github.com/apache/flink-connector-kafka/pull/20

   ## What is the purpose of the change
   
   This PR adds a new method to KafkaSourceBuilder that sets the `client.id` 
config for the KafkaSource to the value returned by the provided Supplier. It 
needs to be a Supplier because it needs to run on the TaskManager, and can't be 
determined at Job submit time like other configs.
   
   ## Brief change log
   
     - *Add setRackId to KafkaSourceBuilder*
     - *Plumb rackId into KafkaPartitionSplitReader*
     - *Add rack id tests*
     -  *Document RackId feature*
   
   
   ## Verifying this change
     - *Added tests for the KafkaSplitReader that verify behaviors for null 
rackId Supplier, null and empty return values, and provided values.*
     - *Manually verified the change by running a 3-node cluster that covered 
two "racks" (AWS Availability Zones) against an Amazon MSK cluster.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs/Javadocs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to