Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r84039201
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ---
    @@ -389,7 +396,22 @@ object AkkaUtils {
           ""
         }
     
    -    ConfigFactory.parseString(configString + hostnameConfigString + 
sslConfigString).resolve()
    +    val cookieConfigString = if(securityEnabled){
    +      s"""
    +         |akka {
    +         |  remote {
    +         |    require-cookie = $requireCookie
    +         |    secure-cookie = "$secureCookie"
    +         |  }
    +         |}
    +         """.stripMargin
    +    }else{
    --- End diff --
    
    No need for the else block. We set set `require-cookie` to `off` in case it 
shouldn't be used


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to