Fanoid commented on code in PR #221:
URL: https://github.com/apache/flink-ml/pull/221#discussion_r1154268534
##########
docs/content/docs/operators/feature/stringindexer.md:
##########
@@ -59,9 +59,10 @@ Below are the parameters required by `StringIndexerModel`.
`StringIndexer` needs parameters above and also below.
-| Key | Default | Type | Required | Description
|
-|-----------------|---------------|--------|----------|-------------------------------------------------------------------------------------------------------------------------------------|
-| stringOrderType | `"arbitrary"` | String | no | How to order strings
of each column. Supported values: 'arbitrary', 'frequencyDesc', 'frequencyAsc',
'alphabetDesc', 'alphabetAsc'. |
+| Key | Default | Type | Required | Description
|
+|-----------------|---------------|---------|----------|-------------------------------------------------------------------------------------------------------------------------------------|
+| stringOrderType | `"arbitrary"` | String | no | How to order strings
of each column. Supported values: 'arbitrary', 'frequencyDesc', 'frequencyAsc',
'alphabetDesc', 'alphabetAsc'. |
+| MaxIndexNum | `2147483647` | Integer | no | The max number of
indices for each column. It only works when stringOrderType is set as
frequencyDesc. |
Review Comment:
nit: add quotes for 'stringOrderType' and 'frequencyDesc', same as other
places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
