Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84041916
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -607,6 +680,18 @@ public int run(String[] args) {
return 1;
}
+ boolean securityEnabled =
yarnDescriptor.getFlinkConfiguration()
+
.getBoolean(ConfigConstants.SECURITY_ENABLED,
+
DEFAULT_SECURITY_ENABLED);
+ LOG.debug("Security Enabled ? {}", securityEnabled);
+
+ //override cookie configuration if supplied through CLI
+ if(securityEnabled && secureCookieArg != null) {
+ LOG.debug("Secure cookie is provided as CLI
argument and will be used");
+
yarnDescriptor.getFlinkConfiguration().setBoolean(ConfigConstants.SECURITY_ENABLED,
true);
+
yarnDescriptor.getFlinkConfiguration().setString(ConfigConstants.SECURITY_COOKIE,
secureCookieArg);
+ }
--- End diff --
So much duplicate code here. Could be extracted to a method to avoid that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
