twalthr commented on code in PR #22313:
URL: https://github.com/apache/flink/pull/22313#discussion_r1157216570
##########
flink-connectors/flink-connector-kafka/pom.xml:
##########
@@ -68,6 +67,22 @@ under the License.
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-runtime</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
Review Comment:
Can't this be a test dependency?
##########
flink-connectors/flink-connector-kafka/pom.xml:
##########
@@ -68,6 +67,22 @@ under the License.
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-runtime</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ <optional>true</optional>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
Review Comment:
Can't this be a test dependency?
##########
flink-connectors/flink-connector-kafka/pom.xml:
##########
@@ -225,6 +241,23 @@ under the License.
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+
<id>forbid-direct-table-planner-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <!-- We need to depend
on table planner because we rely on its internals -->
Review Comment:
Do we rely on planner internals in this module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
