reswqa commented on code in PR #22367:
URL: https://github.com/apache/flink/pull/22367#discussion_r1163942931
##########
flink-core/src/test/java/org/apache/flink/util/concurrent/FutureUtilsTest.java:
##########
@@ -294,7 +294,7 @@ public void testOrTimeout() throws Exception {
final CompletableFuture<String> future = new CompletableFuture<>();
final long timeout = 10L;
- FutureUtils.orTimeout(future, timeout, TimeUnit.MILLISECONDS);
+ FutureUtils.orTimeout(future, timeout, TimeUnit.MILLISECONDS,
"testOrTimeout");
try {
future.get();
Review Comment:
We'd better also check the message of `TimeoutException`.
##########
flink-tests/src/test/java/org/apache/flink/runtime/operators/coordination/OperatorEventSendingCheckpointITCase.java:
##########
@@ -259,7 +259,12 @@ public Long map(Long value) throws Exception {
private static CompletableFuture<Acknowledge> askTimeoutFuture() {
final CompletableFuture<Acknowledge> future = new
CompletableFuture<>();
- FutureUtils.orTimeout(future, 500, TimeUnit.MILLISECONDS);
+ long timeout = 500;
Review Comment:
Can be final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
