libenchao commented on code in PR #22360: URL: https://github.com/apache/flink/pull/22360#discussion_r1164056558
########## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/utils/StringDataConverter.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.jdbc.utils; + +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.data.StringData; + +import java.math.BigDecimal; +import java.sql.Array; +import java.sql.Timestamp; +import java.util.Map; + +/** Converter string value to different value. */ +public class StringDataConverter implements DataConverter { Review Comment: I'm not sure in what cases we'll use this class, could you elaborate a little more? ########## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkResultSet.java: ########## @@ -184,7 +185,7 @@ public int getInt(int columnIndex) throws SQLException { checkValidRow(); checkValidColumn(columnIndex); try { - return currentRow.getInt(columnIndex - 1); Review Comment: According to the comment of `java.sql.ResultSet#getInt`, we need to adjust `null` to the corresponding value. This is the same for other primitive types. ```java * @return the column value; if the value is SQL <code>NULL</code>, the * value returned is <code>0</code> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
