[
https://issues.apache.org/jira/browse/FLINK-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588998#comment-15588998
]
ASF GitHub Bot commented on FLINK-4283:
---------------------------------------
GitHub user AlexanderShoshin opened a pull request:
https://github.com/apache/flink/pull/2661
[FLINK-4283] ExecutionGraphRestartTest fails
Tests were falling by timeout on less than 3 core CPU machines. There were
several graph *RestartStrategies* that blocked threads from the
*ExecutionContext* thread pool by calling '*sleep(Long.MAX_VALUE)*' while
asynchronous graph restarting. This was a cause for some tests to wait for free
threads and to terminate by timeout.
I replaced these *RestartStrategies* by a new testing class
(*InfiniteDelayRestartStrategy*) that has the same functionality - it promises
to restart execution graph after a very long delay. But it doesn't use new
threads from the thread pool. So it can't block other tests execution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AlexanderShoshin/flink
FLINK-4283_infinite_restart_strategy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2661.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2661
----
commit 92fcba525cec6330ddd14643edb675e27afcbdcc
Author: Alexander Shoshin <[email protected]>
Date: 2016-10-18T10:21:51Z
[FLINK-4283] Use new InfiniteDelayRestartStrategy instead of
FixedDelayRestartStrategy to avoid blocking threads
----
> ExecutionGraphRestartTest fails
> -------------------------------
>
> Key: FLINK-4283
> URL: https://issues.apache.org/jira/browse/FLINK-4283
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.1.0
> Environment: Ubuntu 14.04
> W10
> Reporter: Chesnay Schepler
> Assignee: Alexander Shoshin
> Labels: test-stability
>
> I encounter reliable failures for the following tests:
> testRestartAutomatically(org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest)
> Time elapsed: 120.089 sec <<< FAILURE!
> java.lang.AssertionError: expected:<RUNNING> but was:<RESTARTING>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest.restartAfterFailure(ExecutionGraphRestartTest.java:680)
> at
> org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest.testRestartAutomatically(ExecutionGraphRestartTest.java:155)
> taskShouldNotFailWhenFailureRateLimitWasNotExceeded(org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest)
> Time elapsed: 2.055 sec <<< FAILURE!
> java.lang.AssertionError: expected:<RUNNING> but was:<RESTARTING>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest.restartAfterFailure(ExecutionGraphRestartTest.java:680)
> at
> org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest.taskShouldNotFailWhenFailureRateLimitWasNotExceeded(ExecutionGraphRestartTest.java:180)
> testFailingExecutionAfterRestart(org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest)
> Time elapsed: 120.079 sec <<< FAILURE!
> java.lang.AssertionError: expected:<RUNNING> but was:<RESTARTING>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest.testFailingExecutionAfterRestart(ExecutionGraphRestartTest.java:397)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
