haishui126 commented on code in PR #22291:
URL: https://github.com/apache/flink/pull/22291#discussion_r1167685236
##########
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java:
##########
@@ -178,9 +178,18 @@ void announceCombinedWatermark() {
aggregator.getAggregatedWatermark().getTimestamp());
});
- long maxAllowedWatermark =
- globalCombinedWatermark.getTimestamp()
- +
watermarkAlignmentParams.getMaxAllowedWatermarkDrift();
+ long maxAllowedWatermark;
+ try {
+ maxAllowedWatermark =
+ Math.addExact(
+ globalCombinedWatermark.getTimestamp(),
+
watermarkAlignmentParams.getMaxAllowedWatermarkDrift());
+ } catch (ArithmeticException e) {
Review Comment:
This code solves the problem when a Source is idle. I'm worried if there
will be other cases that cause `globalCombinedWatermark.getTimestamp() +
watermarkAlignmentParams.getMaxAllowedWatermarkDrift()` overflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
