Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2667#discussion_r84241679
--- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
@@ -20,11 +20,19 @@
if [ "$1" = "jobmanager" ]; then
echo "Starting Job Manager"
- sed -i -e "s/jobmanager.rpc.address: localhost/jobmanager.rpc.address:
`hostname -f`/g" $FLINK_HOME/conf/flink-conf.yaml
+ #sed -i -e "s/jobmanager.rpc.address:
localhost/jobmanager.rpc.address: `hostname -f`/g"
$FLINK_HOME/conf/flink-conf.yaml
+
+ # make use of container linking and exploit the jobmanager entry in
/etc/hosts
+ sed -i -e "s/jobmanager.rpc.address: localhost/jobmanager.rpc.address:
jobmanager/g" $FLINK_HOME/conf/flink-conf.yaml
+
sed -i -e "s/taskmanager.numberOfTaskSlots:
1/taskmanager.numberOfTaskSlots: `grep -c ^processor /proc/cpuinfo`/g"
$FLINK_HOME/conf/flink-conf.yaml
--- End diff --
This line has to go to the `taskmanager` section. Before, it didn't really
matter because the config was shared but now this setting will just be
configured for the `JobManager` when, in fact, it is only used by the
`TaskManager`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
