vahmed-hamdy commented on code in PR #70: URL: https://github.com/apache/flink-connector-aws/pull/70#discussion_r1177508026
########## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java: ########## @@ -144,6 +150,8 @@ .setMaxBufferedRequests(maxBufferedRequests) .setMaxTimeInBufferMS(maxTimeInBufferMS) .setMaxRecordSizeInBytes(maxRecordSizeInBytes) + .setRateLimitingStrategy( + buildRateLimitingStrategy(maxInFlightRequests, maxBatchSize)) Review Comment: yeah it was uncovered. thanks Danny will add Unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org