gaoyunhaii commented on code in PR #21736: URL: https://github.com/apache/flink/pull/21736#discussion_r1178144717
########## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationOperatorTest.java: ########## @@ -52,9 +51,6 @@ public String getOperatorSnapshotPath(FlinkVersion version) { + "-snapshot"; } - @Ignore @Override - public void writeSnapshot() throws Exception { - throw new UnsupportedOperationException(); - } + public void writeSnapshot(FlinkVersion targetVersion) throws Exception {} Review Comment: It should be because that the base snapshots should only be available in 1.8 ~ 1.11, thus the there is no need to generate snapshots for this test in newer versions. The logic is also the same in the previous version. I added the comment to describe this situation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org