JunRuiLee commented on PR #22427: URL: https://github.com/apache/flink/pull/22427#issuecomment-1524565314
@TanYuxin-tyx Thanks for the explanation and I agree that migrating all the subclasses in one PR is cumbersome and unnecessary. What confuses me is that the title of this PR is "Migrate BatchAbstractTestBase and BatchTestBase to junit5", but the commits also include migration of some subclasses, although not all of them. I am curious why these subclasses were selected for migration. Could you please clarify? Also, I suggest splitting this into different commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
