zhuzhurk commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1185923917


##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java:
##########
@@ -778,7 +778,7 @@ private static PartitionInfo createFinishedPartitionInfo(
      */
     @Override
     public void fail(Throwable t) {
-        processFail(t, true);
+        processFail(t, true, Collections.emptyMap());

Review Comment:
   JM side task failures may originate from SplitEnumerator in 
SourceCoordinator, which is possible to be a user side problem.
   Another kind of failures that users may need to handle is slot allocation 
timeout exceptions, which may be caused by lack of resources. I see that #22511 
targets to handle TM disconnect failures, yet not sure whether this kind of 
failures are covered.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to