Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2669#discussion_r84509867
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java
 ---
    @@ -96,11 +101,20 @@ public void setCommonRpcBindAddress(String 
bindAddress) {
                this.commonBindAddress = bindAddress;
        }
     
    +   public void setManagedMemoryPerTaskManager(long 
managedMemoryPerTaskManager) {
    +           checkArgument(managedMemoryPerTaskManager > 0, "must have more 
than 0 MB of memory for the TaskManager.");
    +           this.managedMemoryPerTaskManager = managedMemoryPerTaskManager;
    +   }
    +
        // 
------------------------------------------------------------------------
        //  getters
        // 
------------------------------------------------------------------------
     
        public Configuration getConfiguration() {
    +           // update the memory in case that we've changed the number of 
components (TM, RM, JM)
    +           long memory = calculateManagedMemoryPerTaskManager();
    --- End diff --
    
    After this method has been called, you can't change the memory 
configuration anymore because the config value will prevent new calculation in 
`calculateManagedMemoryPerTaskManager`. Is that desired?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to