liuml07 opened a new pull request, #22547:
URL: https://github.com/apache/flink/pull/22547

   ## What is the purpose of the change
   
   https://issues.apache.org/jira/browse/FLINK-30081
   
   In local executor, it's not possible to set different values for 
`taskmanager.memory.jvm-overhead.max` and 
`taskmanager.memory.jvm-overhead.min`. When setting them differently, local 
executor reports `Exception in thread "main" 
java.lang.IllegalArgumentException` error.
   
   The problem was that we expect the max and min to equal, but they are not 
resolved to the same value for local executor. Actually the two values are not 
effective for local, we should reset them to the same value.
   
   ## Brief change log
   
   - reset the two JVM overhead config to the same value for local executor
   - fix a bug in l
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
`TaskExecutorResourceUtilsTest`. It also adds a new test case in this class.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to