TanYuxin-tyx commented on code in PR #22352: URL: https://github.com/apache/flink/pull/22352#discussion_r1188316799
########## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManager.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition.hybrid.tiered.storage; + +import org.apache.flink.core.memory.MemorySegment; +import org.apache.flink.runtime.io.network.buffer.BufferPool; +import org.apache.flink.runtime.io.network.buffer.LocalBufferPool; + +/** + * The {@link TieredStorageMemoryManager} is to request or recycle buffer from {@link + * LocalBufferPool} for different tiers or {@link BufferAccumulator}. + * + * <p>The buffers of {@link BufferAccumulator} is also managed in the {@link + * TieredStorageMemoryManager}. When {@link BufferAccumulator} requests or recycles buffers, it uses + * separate methods that are different from tiers. + */ +public interface TieredStorageMemoryManager { + + /** Setup the {@link TieredStorageMemoryManager}. */ + void setup(BufferPool bufferPool); + + /** + * Request a {@link MemorySegment} instance from {@link LocalBufferPool} for a specific tier. + * + * @param tierIndex the tier index + * @return the requested buffer + */ + MemorySegment requestBufferBlocking(int tierIndex); + + /** + * Recycle a {@link MemorySegment} buffer to {@link LocalBufferPool} for a specific tier. + * + * @param memorySegment the buffer to be recycled + * @param tierIndex the specific tier index + */ + void recycleBuffer(MemorySegment memorySegment, int tierIndex); + + /** Request a {@link MemorySegment} buffer for the buffer accumulator. */ + MemorySegment requestBufferInAccumulator(); + + /** Recycle a {@link MemorySegment} buffer for the buffer accumulator. */ + void recycleBufferInAccumulator(MemorySegment memorySegment); Review Comment: I have updated the code. I unified the logic of requesting and recycling buffers of any memory consumer owners. Removed the different interfaces for tiers and the accumulator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
