[GitHub] [flink] becketqin commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

[via GitHub]

becketqin commented on code in PR #22509:
URL: https://github.com/apache/flink/pull/22509#discussion_r1189255125


##########
docs/layouts/shortcodes/generated/yarn_config_configuration.html:
##########
@@ -182,5 +182,15 @@
             <td>String</td>
             <td>Specify YARN node label for the Flink TaskManagers, it will 
override the yarn.application.node-label for TaskManagers if both are set.</td>
         </tr>
+        <tr>
+          <td><h5>yarn.view.acls</h5></td>
+          <td style="word-wrap: break-word;">(none)</td>
+          <td>Users and groups to give VIEW access. The ACLs are of for 
comma-separated-usersspacecomma-separated-groups</td>
+        </tr>
+        <tr>
+          <td><h5>yarn.modify.acls</h5></td>
+          <td style="word-wrap: break-word;">(none)</td>
+          <td>Users and groups to give MODIFY access. The ACLs are of for 
comma-separated-usersspacecomma-separated-groups</td>

Review Comment:
   The format "comma-separated-usersspacecomma-separated-groups" looks a little 
weird.  Can we use "comma-separated-users&lt;space&gt;comma-separated-groups"?



##########
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java:
##########
@@ -231,6 +231,25 @@ public class YarnConfigOptions {
                     .withDescription(
                             "A comma-separated list of tags to apply to the 
Flink YARN application.");
 
+    /**
+     * Users and groups to give VIEW access.
+     * 
https://www.cloudera.com/documentation/enterprise/latest/topics/cm_mc_yarn_acl.html
+     */
+    public static final ConfigOption<String> APPLICATION_VIEW_ACLS =
+            key("yarn.view.acls")
+                    .defaultValue("")

Review Comment:
   We need to define the type first.
   ```
   key("yarn.view.acls")
                       .stringType()
                       .defaultValue("")
   ```



##########
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java:
##########
@@ -231,6 +231,25 @@ public class YarnConfigOptions {
                     .withDescription(
                             "A comma-separated list of tags to apply to the 
Flink YARN application.");
 
+    /**
+     * Users and groups to give VIEW access.
+     * 
https://www.cloudera.com/documentation/enterprise/latest/topics/cm_mc_yarn_acl.html
+     */
+    public static final ConfigOption<String> APPLICATION_VIEW_ACLS =
+            key("yarn.view.acls")
+                    .defaultValue("")
+                    .withDescription(
+                            "Users and groups to give VIEW access. The ACLs 
are of for"
+                                    + " 
comma-separated-usersspacecomma-separated-groups");
+
+    /** Users and groups to give MODIFY access. */
+    public static final ConfigOption<String> APPLICATION_MODIFY_ACLS =
+            key("yarn.modify.acls")
+                    .defaultValue("")

Review Comment:
   dito above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org