[ 
https://issues.apache.org/jira/browse/FLINK-4871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597480#comment-15597480
 ] 

ASF GitHub Bot commented on FLINK-4871:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2669#discussion_r84573150
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java
 ---
    @@ -162,4 +180,63 @@ public String toString() {
                                ", config=" + config +
                                '}';
        }
    +
    +   /**
    +    * Calculate the managed memory per task manager. The memory is 
calculated in the following
    +    * order:
    +    *
    +    * 1. Return {@link #managedMemoryPerTaskManager} if set
    +    * 2. Return 
config.getInteger(ConfigConstants.TASK_MANAGER_MEMORY_SIZE_KEY) if set
    +    * 3. Distribute the available free memory equally among all components 
(JMs, RMs and TMs) and
    +    * calculate the managed memory from the share of memory for a single 
task manager.
    +    *
    +    * @return
    +    */
    +   private long calculateManagedMemoryPerTaskManager() {
    --- End diff --
    
    Yes, will rename the method.


> Add memory calculation for TaskManagers and forward MetricRegistry
> ------------------------------------------------------------------
>
>                 Key: FLINK-4871
>                 URL: https://issues.apache.org/jira/browse/FLINK-4871
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> Add automatic memory calculation for {{TaskManagers}} executed by the 
> {{MiniCluster}}. 
> Additionally, change the {{TaskManagerRunner}} to accept a given 
> {{MetricRegistry}} so that the one instantiated by the {{MiniCluster}} is 
> used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to