afedulov commented on code in PR #22556:
URL: https://github.com/apache/flink/pull/22556#discussion_r1189996733
##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/SqlClientTest.java:
##########
@@ -156,6 +156,23 @@ void testGatewayMode() throws Exception {
assertThat(actual).contains("execution.target", "yarn-session");
}
+ @Test
+ void testGatewayModeUrl() throws Exception {
+ String[] args =
+ new String[] {
+ "gateway",
+ "-e",
+ new URL(
+ "http",
+
SQL_GATEWAY_REST_ENDPOINT_EXTENSION.getTargetAddress(),
+
SQL_GATEWAY_REST_ENDPOINT_EXTENSION.getTargetPort(),
+ "")
+ .toString()
+ };
+ String actual = runSqlClient(args, String.join("\n", "SET;", "QUIT;"),
false);
+ assertThat(actual).contains("execution.target", "yarn-session");
Review Comment:
It does, has to do with how the existing tests are setup:
https://github.com/apache/flink/pull/22556/files#diff-f5e15c60fc56dbc6376b39004c12e41ab6501d130f788ecf421e6f09d597d3daR145-R157
The new one is essentially the same test that just verifies that passing a
URL instead of hostname:port works without changing anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
