snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1190409133
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ########## @@ -526,7 +526,7 @@ private static List<TestSetSpec> allTypesBasic() { .fromCase(BIGINT(), DEFAULT_NEGATIVE_BIGINT, DEFAULT_NEGATIVE_BIGINT) .fromCase(FLOAT(), DEFAULT_POSITIVE_FLOAT, 123L) .fromCase(FLOAT(), DEFAULT_NEGATIVE_FLOAT, -123L) - .fromCase(FLOAT(), 9234567891.12, 9234567891L) + .fromCase(FLOAT(), 9234567891.12, 9234568192L) Review Comment: This looks a bit weird however after checking it the result is same as for ```java Float.parseFloat("9234567891.12"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org